Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate conditionals instead of switch in materializer delegate for discriminator values that need custom comparison #22470

Merged
merged 1 commit into from
Sep 10, 2020
Merged

Generate conditionals instead of switch in materializer delegate for discriminator values that need custom comparison #22470

merged 1 commit into from
Sep 10, 2020

Conversation

ajcvickers
Copy link
Member

Part of #19650

@ajcvickers
Generate conditionals instead of switch in materializer delegate for …
3bc3866 
…discriminator values that need custom comparison

Part of #19650
@ajcvickers ajcvickers requested a review from a team September 9, 2020 22:50
@ajcvickers
Copy link
Member Author

@Pilchie for RC2 (After review and green build.)

@Pilchie
Copy link
Member

Pilchie commented Sep 10, 2020

Approved for .NET 5 RC2.

@ajcvickers ajcvickers merged commit 77c16b4 into release/5.0-rc2 Sep 10, 2020
@ajcvickers ajcvickers deleted the IffySwitches0909 branch September 10, 2020 14:35
@ajcvickers ajcvickers mentioned this pull request Sep 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndriySvyryd AndriySvyryd AndriySvyryd approved these changes

Assignees
No one assigned
Labels
Servicing-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ajcvickers @Pilchie @AndriySvyryd