Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow discriminator properties to have value converter and comparer #22425

Merged
merged 1 commit into from
Sep 8, 2020
Merged

Allow discriminator properties to have value converter and comparer #22425

merged 1 commit into from
Sep 8, 2020

Conversation

ajcvickers
Copy link
Member

Fixes #19650

@ajcvickers ajcvickers requested a review from a team September 6, 2020 20:09
@ajcvickers ajcvickers changed the title Allow discriminator properties to value converter and comparer Allow discriminator properties to have value converter and comparer Sep 6, 2020
@ajcvickers ajcvickers requested review from smitpatel and a team September 7, 2020 18:41
@ajcvickers
Copy link
Member Author

@Pilchie RC2

@Pilchie Pilchie assigned Pilchie and unassigned Pilchie Sep 8, 2020
@Pilchie
Copy link
Member

Pilchie commented Sep 8, 2020

Approved for .NET 5 RC2.Approved for .NET 5 RC2.

@ajcvickers ajcvickers merged commit 3f54048 into release/5.0-rc2 Sep 8, 2020
@ajcvickers ajcvickers deleted the BurningZinc0905 branch September 8, 2020 16:30
@ajcvickers ajcvickers mentioned this pull request Sep 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smitpatel smitpatel smitpatel approved these changes

Assignees
No one assigned
Labels
Servicing-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow discriminator properties to have value converter and comparer
4 participants
@ajcvickers @Pilchie @smitpatel @AndriySvyryd