Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to shared-type entity type handling in proxies #22408

Merged
merged 3 commits into from
Sep 5, 2020
Merged

Updates to shared-type entity type handling in proxies #22408

merged 3 commits into from
Sep 5, 2020

Conversation

ajcvickers
Copy link
Member

Fixes #22337
Fixes #22366

@ajcvickers
Updates to shared-type entity type handling in proxies
debd89b 
Fixes #22337
Fixes #22366

* Check for virtual indexer properties and throw unless type is Dictionary<string, _> and has only primary keys
* Specific exception for the Dictionary case
* Filed #22407, #22406
@ajcvickers ajcvickers requested a review from a team September 4, 2020 21:52
@ajcvickers ajcvickers mentioned this pull request Sep 4, 2020
Closed
@ajcvickers
Copy link
Member Author

@Pilchie RC2

@Pilchie
Copy link
Member

Pilchie commented Sep 4, 2020

Approved for .NET 5.0 RC2.

@ajcvickers ajcvickers merged commit 0610801 into release/5.0-rc2 Sep 5, 2020
@ajcvickers ajcvickers deleted the IfItQuacksLikeAProxy0904 branch September 5, 2020 18:28
@ajcvickers ajcvickers mentioned this pull request Sep 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndriySvyryd AndriySvyryd AndriySvyryd approved these changes

Assignees
No one assigned
Labels
Servicing-approved
Projects
None yet
Milestone
No milestone
3 participants
@ajcvickers @Pilchie @AndriySvyryd