-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tools: Add Get-Migrations and update "migrations list" to show applied or pending #22109
Conversation
|
||
<!-- | ||
Microsoft ResX Schema | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete trailing whitespaces
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
VS adds them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's actually ResXResourceWriter.Generate()
that puts them in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And it's random comments like this that lead to random ideas like #22156 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bricelam: Could you paste URL for this method? (or repository URL)
Maybe someone could fix this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it's fixed in .NET Core. lol, good luck getting it patched in .NET Framework.
https://github.com/dotnet/winforms/blob/master/src/System.Windows.Forms/src/System/Resources/ResXResourceWriter.cs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And yes, it really is in System.Windows.Forms.dll 🤦♂️ (I tried to get it moved in dotnet/winforms#1342)
Manually verified that this works as expected and is both forward (3.1 tools on 5.0 projects) and backward (5.0 tools on 3.1 projects) compatible.
Resolves #577