Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToQueryString for ReadItemQueryingEnumerable #22091

Merged
4 commits merged into from
Aug 18, 2020
Merged

Conversation

ajcvickers
Copy link
Member

Fixes #20653

@ajcvickers ajcvickers requested a review from a team August 16, 2020 21:01
@ghost
Copy link

ghost commented Aug 16, 2020

Hello @ajcvickers!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ajcvickers
Copy link
Member Author

@dotnet/efcore Also added split-query ToQueryString message addendum, as discussed in triage.

@smitpatel smitpatel changed the base branch from main to release/5.0 August 17, 2020 22:30
Also added message for split query, as discussed in triage.
Fix issue trying to execute non-executable SQL
@ghost ghost merged commit dd80092 into release/5.0 Aug 18, 2020
@ghost ghost deleted the NoOneWillNotice0816 branch August 18, 2020 16:46
public override Task Include_collection_with_last_no_orderby(bool async)
{
return AssertTranslationFailedWithDetails(
() => AssertLast(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should call base.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cosmos: ToQueryString for ReadItemQueryingEnumerable
3 participants