Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type mapping fixes from API reviews #22032

Merged
merged 1 commit into from
Aug 12, 2020
Merged

Type mapping fixes from API reviews #22032

merged 1 commit into from
Aug 12, 2020

Conversation

ajcvickers
Copy link
Member

  • Removed StoreTypeNameBaseUsesPrecision
  • Removed large GetMapping overload that was added in 5.0 but is never called
  • Fixed issue when reverse engineering where different casing for type name was being ignored

Part of #20409

@ajcvickers
Type mapping fixes from API reviews
3fb7e75 
* Removed `StoreTypeNameBaseUsesPrecision`
* Removed large GetMapping overload that was added in 5.0 but is never called
* Fixed issue when reverse engineering where different casing for type name was being ignored

Part of #20409
@ajcvickers ajcvickers requested a review from a team August 12, 2020 16:08
@ajcvickers ajcvickers merged commit dc540f1 into main Aug 12, 2020
@ajcvickers ajcvickers deleted the DreJustLetItRunAyo0812 branch August 12, 2020 19:17
@ajcvickers ajcvickers mentioned this pull request Aug 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smitpatel smitpatel smitpatel approved these changes

Assignees
No one assigned
Labels
providers-beware
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ajcvickers @smitpatel @AndriySvyryd