Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/5.0-preview8] SQLite Migrations: Test table rebuilds #21783

Merged
merged 1 commit into from
Jul 25, 2020

Conversation

bricelam
Copy link
Contributor

@bricelam bricelam commented Jul 25, 2020

Simplified some things. Fixed a few issues. Removed some mostly dead code. (We'll never generate migrations for it and users are unlikely to ever manually write migrations for it.)

Part of #329

@bricelam bricelam requested a review from a team July 25, 2020 05:28
@ghost
Copy link

ghost commented Jul 25, 2020

Hello @bricelam!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost
Copy link

ghost commented Jul 25, 2020

Apologies, while this PR appears ready to be merged, it looks like release/5.0-preview8 is a protected branch and I have not been granted permission to perform the merge.

@ghost
Copy link

ghost commented Jul 25, 2020

Apologies, while this PR appears ready to be merged, it looks like release/5.0-preview8 is a protected branch and I have not been granted permission to perform the merge.

@ajcvickers ajcvickers merged commit 5912246 into dotnet:release/5.0-preview8 Jul 25, 2020
@bricelam bricelam deleted the rebuild2 branch July 26, 2020 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants