Fix to #19609 - Query: allow user functions to be annotated with nullability propagation information #21777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
requested changes
Jul 24, 2020
src/EFCore.Relational/Metadata/Builders/DbFunctionBuilderBase.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Relational/Query/RelationalMethodCallTranslatorProvider.cs
Outdated
Show resolved
Hide resolved
|
updated |
src/EFCore.Relational/Query/RelationalMethodCallTranslatorProvider.cs
Outdated
Show resolved
Hide resolved
|
updated |
src/EFCore.Relational/Metadata/Conventions/RelationalDbFunctionAttributeConvention.cs
Outdated
Show resolved
Hide resolved
AndriySvyryd
approved these changes
Jul 25, 2020
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
maumar
force-pushed
the
fix19609
branch
2 times, most recently
from
f53fe59
to
292f133
Compare
smitpatel
reviewed
Jul 27, 2020
src/EFCore.Relational/Metadata/Conventions/RelationalDbFunctionAttributeConvention.cs
Outdated
Show resolved
Hide resolved
smitpatel
reviewed
Jul 27, 2020
smitpatel
reviewed
Jul 27, 2020
smitpatel
reviewed
Jul 27, 2020
smitpatel
reviewed
Jul 27, 2020
test/EFCore.Relational.Specification.Tests/Query/UdfDbFunctionTestBase.cs
Outdated
Show resolved
Hide resolved
…ability propagation information Added fluent API for function to specify it's nullability and function parameter to specify whether it propagates null. Also added property to DbFunction attribute to allow specify nullability there.
|
updated @smitpatel |
smitpatel
approved these changes
Jul 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added fluent API for function to specify it's nullability and function parameter to specify whether it propagates null. Also added property to DbFunction attribute to allow specify nullability there.
Fixes #19609