Query: Use correct column mappings for TVF/FromSql #21722
Conversation
|
Hello @smitpatel! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
@msftbot require 1 approval |
|
Hello @smitpatel! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
| break; | ||
|
|
||
| default: | ||
| table = entityType.GetDefaultMappings().Single().Table; |
There was a problem hiding this comment.
Would be cleaner if TableExpressionBase had an ITableBase property
There was a problem hiding this comment.
Select/Joins etc also are TableExpressionBase. They don't correspond to any ITableBase.
TableExpressionBase is anything from which you can project out columns. ITableBase correspond to actual database object only so we would need some middle type to hold it.
There was a problem hiding this comment.
The ITableBase property could be null if there's no database object
There was a problem hiding this comment.
I added TableExpressiob.Table & TVFExpression.StoreFunction.
I will revisit if FromSqlExpression should take ITableBase when I work in ToQuerySql API.
Resolves #21511