Set max batch size for SQL Server #21704
Conversation
|
Hello @AndriySvyryd! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
@msftbot Require 1 sign off |
|
Hello @AndriySvyryd! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
| @@ -45,7 +45,7 @@ public class SqlServerModificationCommandBatch : AffectedCountModificationComman | |||
| throw new ArgumentOutOfRangeException(nameof(maxBatchSize), RelationalStrings.InvalidMaxBatchSize); | |||
| } | |||
|
|
|||
| _maxBatchSize = Math.Min(maxBatchSize ?? int.MaxValue, MaxRowCount); | |||
| _maxBatchSize = Math.Min(maxBatchSize ?? 42, MaxRowCount); | |||
There was a problem hiding this comment.
@AndriySvyryd how are you?
Just out of curiosity, any specific reason for reaching number 42?
it's just curiosity.
There was a problem hiding this comment.
Sorry, now I looked at issue #9270
There was a problem hiding this comment.
Just out of curiosity, any specific reason for reaching number 42?
Only because it's the answer to the Ultimate Question of Life, the Universe, and Everything and it has better perf in common scenarios than the implicit default of ~2100
There was a problem hiding this comment.
Thank u, living and learning!
ghost
merged commit 
Fixes #9270