Query: Convert "APPLY" to "JOIN" with skip via RowNumber #21282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves #17326 This enables filtered include with skip to be translated for Sqlite
smitpatel
force-pushed
the
smit/ConvertLimit
branch
from
486dfc2
to
7267c65
Compare
bricelam
approved these changes
Jun 16, 2020
maumar
reviewed
Jun 16, 2020
| SqlExpression limitPredicate = null; | ||
| if (offset != null) | ||
| { | ||
| offsetPredicate = new SqlBinaryExpression( |
There was a problem hiding this comment.
since we add a lot of artificial skip 0, we could recognize this pattern and remove the redundant WHERE 0 < [t].[row] from queries
There was a problem hiding this comment.
looks like i'm late to the party - filed #21290 to track this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #17326
This enables filtered include with skip to be translated for Sqlite