Query: DRY SelectExpression.AddJoin #21248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maumar
reviewed
Jun 15, 2020
| @@ -1184,6 +1213,18 @@ static Expression RemoveConvert(Expression expression) | |||
| } | |||
| } | |||
|
|
|||
| private sealed class EntityShaperNullableMarkingExpressionVisitor : ExpressionVisitor | |||
There was a problem hiding this comment.
worth moving from QueryableMethodTranslatingEV into some common place and use that one, rather can creating a new one here?
There was a problem hiding this comment.
It is going to be removed from Queryable one and let provider deal with it since provider specific query expression are supposed to use it if needed. We can move it to something shared when dealing with InMemory if worth. The method is also supposed to be obsoleted but not done yet for the same InMemory reason.
maumar
approved these changes
Jun 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #21226