Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query: Introduce FromSqlQueryingEnumerable for non composed FromSql #21180

Merged
merged 1 commit into from
Jun 10, 2020

Conversation

smitpatel
Copy link
Member

  • Move ReaderColumns to RelationalCommandCache

@ErikEJ
Copy link
Contributor

ErikEJ commented Jun 9, 2020

What problem does this fix?

@smitpatel
Copy link
Member Author

@ErikEJ - It does not fix any problem directly. Currently we have QueryingEnumerable which works for both non composed FromSql and regular query too. The "optional" index map parameter lies around. It was ok refactor.
But now I also need to add a QueryingEnumerable for split query scenario which would actually materialize quite differently. So it seemed that splitting each in separate Enumerable is simpler to process. (See #21181 which combines different phases of processing shaper into one #21189 which introduces 3rd kind of QueryingEnumerable).

@smitpatel smitpatel changed the base branch from release/5.0-preview6 to feature/splitInclude June 10, 2020 05:22
- Move ReaderColumns to RelationalCommandCache
@smitpatel smitpatel merged commit bf0eed4 into feature/splitInclude Jun 10, 2020
@smitpatel smitpatel deleted the smit/queryablerefactor branch June 10, 2020 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants