Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SMALL] Adding regression tests for #12826 - Query: Incorrect syntax near the keyword 'AS` for group by aggregate #21077

Merged
merged 1 commit into from
Jun 19, 2020
Merged

[SMALL] Adding regression tests for #12826 - Query: Incorrect syntax near the keyword 'AS` for group by aggregate #21077

merged 1 commit into from
Jun 19, 2020

Conversation

maumar
Copy link
Contributor

@maumar maumar commented May 29, 2020

Resolves #12826

@maumar maumar requested a review from smitpatel May 29, 2020 08:48
@smitpatel smitpatel self-assigned this May 29, 2020
@smitpatel
Copy link
Member

Can you check if covered by existing tests (or if I missed in tests you added) following scenarios:
#12658 - Element selector with coalesce and being repeated in aggregate.
#12656 - Key + Key in projection
#12564 - projecting constant on top level
#12577 - Composition after projecting key out of group by, pushdown on that and then projecting length.
#11453 - A doubly nested object constructed from key properties (probably mix it up with key properties and aggregate scalars too)
#13150 - Element selector with case block repeated inside another case block in projection.

@smitpatel
Copy link
Member

Ping @maumar

@maumar
Copy link
Contributor Author

maumar commented Jun 17, 2020

12577 was already there, added the rest @smitpatel

@smitpatel smitpatel removed their assignment Jun 19, 2020
@maumar
Adding regression tests for #12826 - Query: Incorrect syntax near the…
1370d57 
… keyword 'AS` for group by aggregate

Resolves #12826
@maumar maumar merged commit 1370d57 into master Jun 19, 2020
@maumar maumar deleted the fix12826 branch June 19, 2020 06:28
@ajcvickers ajcvickers mentioned this pull request Jun 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smitpatel smitpatel smitpatel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Query: Incorrect syntax near the keyword 'AS` for group by aggregate
2 participants
@maumar @smitpatel