Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query: Proper extensibility support for parameter value based SQL processor #20883

Merged
merged 1 commit into from
May 7, 2020
Merged

Query: Proper extensibility support for parameter value based SQL processor #20883

merged 1 commit into from
May 7, 2020

Conversation

smitpatel
Copy link
Member

  • Methods to override only parts of Sql Processor
  • Consistent shape of methods taking SelectExpression/parameter values and canCache via out variable
  • Initialize the inner visitors only once during creation

@smitpatel
Query: Proper extensibility support for parameter value based SQL pro…
59187c0 
…cessor

- Methods to override only parts of Sql Processor
- Consistent shape of methods taking SelectExpression/parameter values and canCache via out variable
- Initialize the inner visitors only once during creation
@smitpatel smitpatel merged commit f899240 into master May 7, 2020
@smitpatel smitpatel deleted the smit/services branch May 7, 2020 21:42
@ajcvickers ajcvickers mentioned this pull request May 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndriySvyryd AndriySvyryd AndriySvyryd approved these changes

@maumar maumar Awaiting requested review from maumar

@ajcvickers ajcvickers Awaiting requested review from ajcvickers

@roji roji Awaiting requested review from roji

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smitpatel @AndriySvyryd