Cleanup some of the internal API usage in Relational #20388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
smitpatel
commented
Mar 23, 2020
smitpatel
commented
- Make EnumerableExtensions shared internal
- Make ExpressionEqualityComparer public
- Suppress Internal usage in EntityFrameworkRelationalServicesBuilder
- Make ConfigurationSourceExtensions public
- Suppress convention-less modelBuilder creation in Migration/Snapshot
smitpatel
force-pushed
the
smit/BinomialDistribution
branch
from
bab82e5
to
b8b6c31
Compare
| @@ -54,6 +65,14 @@ public static IEnumerable<IMutableEntityType> GetDerivedTypesInclusive([NotNull] | |||
| public static IEnumerable<IMutableEntityType> GetDirectlyDerivedTypes([NotNull] this IMutableEntityType entityType) | |||
| => ((EntityType)entityType).GetDirectlyDerivedTypes(); | |||
|
|
|||
| /// <summary> | |||
| /// Returns all types in hierarchy of the given <see cref="IMutableEntityType" />. | |||
There was a problem hiding this comment.
Technically it only returns all base and derived types (no siblings)
AndriySvyryd
approved these changes
Mar 24, 2020
- Make EnumerableExtensions shared internal - Make ExpressionEqualityComparer public - Suppress Internal usage in EntityFrameworkRelationalServicesBuilder - Make ConfigurationSourceExtensions public - Suppress convention-less modelBuilder creation in Migration/Snapshot
smitpatel
force-pushed
the
smit/BinomialDistribution
branch
from
b8b6c31
to
e794c53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.