Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for 17509. Do not allow migration to have same name as context. #20143

Merged
merged 1 commit into from
Mar 3, 2020
Merged

Fix for 17509. Do not allow migration to have same name as context. #20143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/EFCore.Design/Design/Internal/MigrationsOperations.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,13 @@ public virtual MigrationFiles AddMigration(
var subNamespace = SubnamespaceFromOutputPath(outputDir);

using var context = _contextOperations.CreateContext(contextType);
var contextClassName = context.GetType().Name;
if (string.Equals(name, contextClassName, StringComparison.Ordinal))
{
throw new OperationException(
DesignStrings.ConflictingContextAndMigrationName(name));
}

var services = _servicesBuilder.Build(context);
EnsureServices(services);
EnsureMigrationsAssembly(services);
Expand Down
12 changes: 10 additions & 2 deletions src/EFCore.Design/Properties/DesignStrings.Designer.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions src/EFCore.Design/Properties/DesignStrings.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,4 +363,7 @@ Change your target project to the migrations project by using the Package Manage
<data name="UnhandledEnumValue" xml:space="preserve">
<value>Unhandled enum value '{enumValue}'.</value>
</data>
<data name="ConflictingContextAndMigrationName" xml:space="preserve">
<value>The name you have chosen for the migration, '{name}', is the same as the context class name. Please choose a different name for your migration. Might we suggest 'InitialCreate' for your first migration?</value>
</data>
</root>