New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #19720 single parenthesis defaults #19745

Merged

bricelam merged 1 commit into dotnet:master from mikes-gh:Fix-Defaults

Feb 7, 2020

Contributor

mikes-gh commented Jan 30, 2020 •

edited

Loading

Allows DEFAULT with single or double parenthesis to remove unnecessary HasDefaultValueSql

It appears that schemas generated with older version of SSMS tools or DDL commands have produced defaults in the format
e.g. DEFAULT (0)
Modern tools always generate DEFAULT ((0))
It seems inexpensive to test for legacy schema DEFAULT (0)


          Fixes #19720 single parenthesis defaults

61a9e8a

ajcvickers assigned bricelam

bricelam approved these changes

View reviewed changes

bricelam added the accepted label

bricelam merged commit 584245c into dotnet:master

ajcvickers mentioned this pull request

Entity Framework Weekly Status Updates (2020) #19549

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet