Extract INavigationBase #19504
Merged
Extract INavigationBase #19504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stackoverflow 😢 |
AndriySvyryd
force-pushed
the
NavigationBase
branch
from
d8f16b2
to
8a558e6
Compare
smitpatel
reviewed
Jan 8, 2020
| @@ -398,7 +398,7 @@ private BlockExpression AddIncludes(BlockExpression shaperBlock) | |||
| INavigation navigation, | |||
| INavigation inverseNavigation, | |||
| Action<TIncludingEntity, TIncludedEntity> fixup, | |||
| Action<TIncludingEntity> initialize) | |||
There was a problem hiding this comment.
Can we remove this if not used?
There was a problem hiding this comment.
No, it must have the same number of parameters as IncludeCollection to make the code simpler
smitpatel
approved these changes
Jan 8, 2020
Part of #19003
AndriySvyryd
force-pushed
the
NavigationBase
branch
from
8a558e6
to
4498374
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #19003