Exclude Object when checking for DbContext in query filters #18761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roji
force-pushed
the
ObjectIdentifiedAsContext
branch
from
35587b3 to
c0bb431
Compare
|
Querybugstest is fine. This is core functionality so we are not missing out anything by running on only 1 provider. |
smitpatel
approved these changes
Nov 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18759
@smitpatel if we really want to avoid QueryBugsTest we can simply remove the equality operator from Customer and the bug should repro in FiltersQueryBase.Entity_Equality. But this seems subtle enough that a query bug test makes sense (i.e. to avoid someone defining an operator again in the future). Let me know what you prefer.