Solve the 3.0 regression: Cannot use generics w/ interface to construct expression bug #18651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
… wrong property name exception * Change the EFCore.Relational and EFCore.InMemory TranslatingExpressionVisitors to handle interface conversion and bypass it Fixes #17794
|
This is incorrect fix. If the interface is unknown and we are in client eval, we need to preserve it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change re-writes an expression to skip over UnaryExpressions where the inner expression is an interface. I am not sure if this is the appropriate way to implement this, however it works for the test case I created. This bug is a blocker on us migrating to 3.x as we use this generic interface, so will be very happy if this is merged.
I have tested and verified these changes on the release/3.0 branch and can make a PR for that instead if that were helpful.
Fixes #17794