Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor RelationalShapedQueryCompilingExpressionVisitor #18649

Merged
merged 1 commit into from
Oct 30, 2019
Merged

Refactor RelationalShapedQueryCompilingExpressionVisitor #18649

merged 1 commit into from
Oct 30, 2019

Conversation

AndriySvyryd
Copy link
Member

Move some nested classes to Internal

@AndriySvyryd AndriySvyryd force-pushed the RefactorRelationalShapedQueryCompilingExpressionVisitor branch from 84e1b29 to 07bc5d2 Compare October 30, 2019 01:48
@AndriySvyryd AndriySvyryd force-pushed the RefactorRelationalShapedQueryCompilingExpressionVisitor branch from 07bc5d2 to b21099b Compare October 30, 2019 04:06
smitpatel
smitpatel approved these changes Oct 30, 2019
View reviewed changes
Copy link
Contributor

@smitpatel smitpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the changes, the amazing multi-level nesting of private classes we had. :trollface:

@AndriySvyryd AndriySvyryd merged commit a0aac5c into release/3.1 Oct 30, 2019
@AndriySvyryd AndriySvyryd deleted the RefactorRelationalShapedQueryCompilingExpressionVisitor branch October 30, 2019 06:51
@ajcvickers ajcvickers mentioned this pull request Oct 31, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smitpatel smitpatel smitpatel approved these changes

@Pilchie Pilchie Awaiting requested review from Pilchie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndriySvyryd @smitpatel