Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some NRT tests for inheritance #18473

Merged
merged 1 commit into from
Oct 22, 2019
Merged

Add some NRT tests for inheritance #18473

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions test/EFCore.Tests/Metadata/Conventions/NonNullableReferencePropertyConventionTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,9 @@ public void Non_nullability_sets_is_nullable_with_conventional_builder()
[InlineData(typeof(B), nameof(B.NullableValueType), true)]
[InlineData(typeof(B), nameof(B.NonNullableRefType), false)]
[InlineData(typeof(B), nameof(B.NullableRefType), true)]
[InlineData(typeof(DerivedClass), nameof(DerivedClass.NonNullable), false)]
[InlineData(typeof(DerivedClass), nameof(DerivedClass.Nullable), true)]
[InlineData(typeof(BaseClass), nameof(DerivedClass.Nullable), true)]
public void Reference_nullability_sets_is_nullable_correctly(Type type, string propertyName, bool expectedNullable)
{
var modelBuilder = CreateModelBuilder();
Expand Down Expand Up @@ -154,6 +157,16 @@ public class B
public string NonNullableRefType { get; set; } = "";
public string? NullableRefType { get; set; }
}

public class DerivedClass : BaseClass
{
public string NonNullable { get; set; } = default!;
}

public class BaseClass
{
public string? Nullable { get; set; }
}
#nullable disable

private static ModelBuilder CreateModelBuilder() => InMemoryTestHelpers.Instance.CreateConventionBuilder();
Expand Down