Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some workarounds #16849

Merged
merged 1 commit into from
Jul 30, 2019
Merged

Remove some workarounds #16849

merged 1 commit into from
Jul 30, 2019

Conversation

bricelam
Copy link
Contributor

No description provided.

@bricelam bricelam requested a review from dougbu as a code owner July 30, 2019 17:27
@smitpatel
Copy link
Contributor

Conflicts blocking checks

Copy link
Member

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question but looks fine if everything builds after resolving conflicts.

@@ -4,8 +4,6 @@
<TargetFramework>netcoreapp3.0</TargetFramework>
<AssemblyName>Microsoft.EntityFrameworkCore.CrossStore.FunctionalTests</AssemblyName>
<RootNamespace>Microsoft.EntityFrameworkCore</RootNamespace>
<!-- Workaround https://github.com/Microsoft/vstest/issues/792. -->
<HasRuntimeOutput>true</HasRuntimeOutput>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure this issue is resolved? Looks like it was reopened a while ago.

Copy link
Contributor Author

@bricelam bricelam Jul 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests passed

@bricelam bricelam merged commit 33f8699 into dotnet:release/3.0 Jul 30, 2019
@bricelam bricelam deleted the cleanup branch July 30, 2019 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants