Re-work InterceptionResult per API review feedback #16661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajcvickers
requested review from
smitpatel,
roji,
AndriySvyryd,
divega and
bricelam
ajcvickers
force-pushed
the
CuzYouAllHateMyStruct0718
branch
from
e8eb57b to
ed67046
Compare
roji
reviewed
Jul 19, 2019
| /// </para> | ||
| /// <exception cref="InvalidOperationException"> when <see cref="Result" /> is false. </exception> | ||
| /// </summary> | ||
| public TResult Result |
There was a problem hiding this comment.
This can be a single-line expression-bodied property with a conditional expression.
Specifically, not using `Nullable` anymore and instead being explicit about suppression/result.
ajcvickers
force-pushed
the
CuzYouAllHateMyStruct0718
branch
from
ed67046 to
5a670e3
Compare
|
Pushed the wrong branch this morning; should be good now. |
smitpatel
approved these changes
Jul 19, 2019
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, not using
Nullableanymore and instead being explicit about suppression/result.