Query: Remove implicit convert nodes in query to avoid unnecessary cast in generated SQL #15954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st in generated SQL Enable BuiltInDataTypeTests - Preserve convert nodes around parameters/constants in parameter extracting. - While translating to Sql, remove implicit convert nodes. Implicit convert nodes appear only for binary expressions since equality operators are not defined for all types - Apply explicit cast in SQL only when converted type is mapped. - Convert int value to enum value before printing literal (how old pipeline did it) Resolves #14159 Resolves #15330 Resolves #15948
maumar
approved these changes
Jun 5, 2019
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable BuiltInDataTypeTests
Resolves #14159
Resolves #15330
Resolves #15948
Supersedes type inference changes in #15820