Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correcting navigation expansion handling of owned navigations #15942

Merged
merged 1 commit into from
Jun 5, 2019

Conversation

maumar
Copy link
Contributor

@maumar maumar commented Jun 4, 2019

Navigation expansion should not try expand owned navigations. We still add them to navigation tree for tracking purposes but we don't inject LeftJoin calls when processing them.
Collection navigations are converted directly to NavigationExpansionExpressions whose root is the navigation itself to avoid rewrite to a subquery.

@maumar maumar requested a review from smitpatel June 4, 2019 19:42
@maumar maumar force-pushed the owned_nav_rewrite branch from 86bddc6 to 4b4d434 Compare June 4, 2019 22:05
@maumar maumar changed the title Correctig navigatgion expansion handling of owned navigations Correcting navigation expansion handling of owned navigations Jun 4, 2019
var entry = _internalEntityEntryFactory.Create(this, entityType, entity, valueBuffer);
i = 0;
var shadowPropertyValuesArray = new object[entityType.ShadowPropertyCount()];
foreach (var shadowProperty in entityType.GetProperties().Where(p => p.IsShadowProperty()))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge with the other for each with if on shadow property

Copy link
Contributor

@smitpatel smitpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Navigation expansion should not try expand owned navigations. We still add them to navigation tree for tracking purposes but we don't inject LeftJoin calls when processing them.
Collection navigations are converted directly to NavigationExpansionExpressions whose root is the navigation itself to avoid rewrite to a subquery.
@maumar maumar force-pushed the owned_nav_rewrite branch from 4b4d434 to af9e222 Compare June 5, 2019 00:38
@maumar maumar merged commit af9e222 into master Jun 5, 2019
@ghost ghost deleted the owned_nav_rewrite branch June 5, 2019 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants