Query: Implement inheritance support for relational layer #15809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
smitpatel
commented
May 25, 2019
smitpatel
commented
- Add discriminator predicate in SelectExpression (filed Query: Optimize discriminator predicates in select expression #15808 to remove redundant)
- Add TPH support in materializer. This happens at core level now
- Add translation for is operator inside lambda
- Add translation for OfType method
|
@roji - This involves some breaking changes or disabled tests which has overlap with FromSql. |
maumar
reviewed
May 28, 2019
src/EFCore.Relational/Query/Pipeline/RelationalQueryableMethodTranslatingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
maumar
reviewed
May 28, 2019
roji
reviewed
May 28, 2019
src/EFCore.Relational/Query/Pipeline/RelationalQueryableMethodTranslatingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Relational/Query/Pipeline/RelationalSqlTranslatingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Relational/Query/Pipeline/RelationalSqlTranslatingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Relational/Query/Pipeline/RelationalSqlTranslatingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
|
Will try to do a more in-depth review tomorrow, but the little I saw made total sense.. |
|
I will rebase on master then. |
maumar
reviewed
May 29, 2019
roji
reviewed
May 29, 2019
src/EFCore.Relational/Query/Pipeline/RelationalSqlTranslatingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
smitpatel
force-pushed
the
smit/InHurryStance
branch
2 times, most recently
from
0bbe740 to
2405a18
Compare
- Add discriminator predicate in SelectExpression (filed #15808 to remove redundant) - Add TPH support in materializer. This happens at core level now - Add translation for is operator inside lambda - Add translation for OfType method
smitpatel
force-pushed
the
smit/InHurryStance
branch
from
2405a18 to
feed50c
Compare
maumar
approved these changes
May 29, 2019
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.