[2.1] Throw for defining query or view mapping on derived query types #11812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
reviewed
Apr 25, 2018
| @@ -477,4 +477,7 @@ | |||
| <value>A SQL parameter or literal was generated for the type '{type}' using the ValueConverter '{valueConverter}'. Review the generated SQL for correctness and consider evaluating the target expression in-memory instead.</value> | |||
| <comment>Warning RelationalEventId.ValueConversionSqlLiteralWarning object object</comment> | |||
| </data> | |||
| <data name="DerivedQueryTypeView" xml:space="preserve"> | |||
| <value>The query type '{queryType}' cannot be mapped to a view bacause it is dervived from '{baseType}'. Only base query types can be mapped to a view.</value> | |||
smitpatel
reviewed
Apr 25, 2018
| continue; | ||
| } | ||
|
|
||
| if (entityType.Relational().TableName != null |
anpete
reviewed
Apr 25, 2018
| @@ -1078,4 +1078,7 @@ | |||
| <data name="ErrorInvalidQueryable" xml:space="preserve"> | |||
| <value>Cannot use multiple DbContext instances within a single query execution. Ensure the query uses a single context instance.</value> | |||
| </data> | |||
| <data name="DerivedQueryTypeDefiningQuery" xml:space="preserve"> | |||
| <value>The query type '{queryType}' cannot have a defining query bacause it is dervived from '{baseType}'. Only base query types can have a defining query.</value> | |||
anpete
approved these changes
Apr 25, 2018
AndriySvyryd
force-pushed
the
Issue11789
branch
from
ae18215 to
70b3704
Compare
ajcvickers
approved these changes
Apr 25, 2018
AndriySvyryd
force-pushed
the
Issue11789
branch
from
70b3704 to
6be065c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11789
Fixes #11808