-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Async Transaction APIs #9015
Comments
Thanks @caleblloyd for the information. I think we agree that the long term solution would be for the base ADO.NET classes to add these capabilities. Can you please make a comment in dotnet/corefx#10975 detailing what your MySQL provider could use? Maybe there is something we can do on EF Core in the shorter term. We will discuss it in triage. |
If #9014 gets fixed, then more transaction related code is going to get into I opened a PR in #9017 with my idea about what this would look like as a solution for just EF. Basically we move the async APIs that we want ADO.NET |
@ajcvickers, I think you are about to fix this, so assigning to 3.0. |
@divega opened this to CoreFX a while ago: https://github.com/dotnet/corefx/issues/10975 but it doesn't look like there has been any movement.
Our ADO.NET provider, MySqlConnector has BeginTransactionAsync, CommitAsync, and RollbackAsync
We like to use them in Pomelo.EntityFrameworkCore.MySql to avoid running Sync-Over-Async I/O and cut down on thread pool lockups.
EF does not lend itself well to supporting these Async methods. We have to override every single method that begins, commits, or rolls back a transaction in our provider.
I think that EF should add a class that allows for the provider to define whether or not it supports Async transaction APIs, and use those instead of the Sync ones if it does.
The text was updated successfully, but these errors were encountered: