Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify InvokeDotnetEf in EntityFramework.psm1 to use .Path instead of .Source to discover dotnet location #5327

Closed
pranavkm opened this issue May 10, 2016 · 11 comments
Assignees
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone

Comments

@pranavkm
Copy link
Contributor

According to https://msdn.microsoft.com/en-us/library/system.management.automation.applicationinfo_members(v=vs.85).aspx, the .Source property on ApplicationInfo returned by Get-Command was added in Powershell 5.0. .Path returns the same value and works in powershell 3.0.

Line of code to change: https://github.com/aspnet/EntityFramework/blob/dev/src/Microsoft.EntityFrameworkCore.Tools/tools/EntityFramework.psm1#L643

@pranavkm
Copy link
Contributor Author

To perform EF migrations in the package manager console until this is fixed, install powershell 5.0.

@divega
Copy link
Contributor

divega commented May 11, 2016

@rowanmiller I talked to @natemcmaster and we think we should take a fix for this now.

@divega divega added this to the 1.0.0-rc2 milestone May 11, 2016
@divega divega added the pri0 label May 11, 2016
@divega
Copy link
Contributor

divega commented May 11, 2016

FWIW the rationale for taking this now is that:

  1. The PMC commands are the tooling option that works for the greatest set of scenarios in RC2
  2. I believe the user gets a very unhelpful exception
  3. PowerShell 5.0 requires extra downloads for Windows 7, 8, 8.1 and the corresponding server SKUs.

@rowanmiller
Copy link
Contributor

Sounds fine to me... should be a low risk fix

@natemcmaster
Copy link
Contributor

To be clear, this only affects users on *.xproj. PMC commands for csproj are unaffected by this.

@rowanmiller rowanmiller modified the milestones: 1.0.0, 1.0.0-rc2 May 11, 2016
@rowanmiller
Copy link
Contributor

Spoke with @danroth27, this does not meet the bar to reset RC2 builds. Moving to RTM.

@ErikEJ
Copy link
Contributor

ErikEJ commented May 11, 2016

So Windows 10 or manual changes to the psm1 file will be required in rc2?

@natemcmaster
Copy link
Contributor

Or upgrade to Powershell 5. https://www.microsoft.com/en-us/download/details.aspx?id=50395

@rowanmiller
Copy link
Contributor

Upgrading PS would be our guidance over modifying the scripts

@ErikEJ
Copy link
Contributor

ErikEJ commented May 11, 2016

Of course!

@divega
Copy link
Contributor

divega commented May 11, 2016

Download link for PowerShell 5.0: https://www.microsoft.com/en-us/download/details.aspx?id=50395

@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Development

No branches or pull requests

6 participants