-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify InvokeDotnetEf in EntityFramework.psm1 to use .Path instead of .Source to discover dotnet location #5327
Comments
To perform EF migrations in the package manager console until this is fixed, install powershell 5.0. |
@rowanmiller I talked to @natemcmaster and we think we should take a fix for this now. |
FWIW the rationale for taking this now is that:
|
Sounds fine to me... should be a low risk fix |
To be clear, this only affects users on *.xproj. PMC commands for csproj are unaffected by this. |
Spoke with @danroth27, this does not meet the bar to reset RC2 builds. Moving to RTM. |
So Windows 10 or manual changes to the psm1 file will be required in rc2? |
Or upgrade to Powershell 5. https://www.microsoft.com/en-us/download/details.aspx?id=50395 |
Upgrading PS would be our guidance over modifying the scripts |
Of course! |
Download link for PowerShell 5.0: https://www.microsoft.com/en-us/download/details.aspx?id=50395 |
According to https://msdn.microsoft.com/en-us/library/system.management.automation.applicationinfo_members(v=vs.85).aspx, the
.Source
property onApplicationInfo
returned byGet-Command
was added in Powershell 5.0..Path
returns the same value and works in powershell 3.0.Line of code to change: https://github.com/aspnet/EntityFramework/blob/dev/src/Microsoft.EntityFrameworkCore.Tools/tools/EntityFramework.psm1#L643
The text was updated successfully, but these errors were encountered: