Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate precompiled query generation into the build process #33103

Closed
roji opened this issue Feb 15, 2024 · 0 comments · Fixed by #33747
Closed

Integrate precompiled query generation into the build process #33103

roji opened this issue Feb 15, 2024 · 0 comments · Fixed by #33747
Labels
area-aot area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
9.0.0

Comments

@roji
Copy link
Member

roji commented Feb 15, 2024

The precompiled query feature (#25009) statically analyzes user code, and generates interceptors for static LINQ queries; this is necessary for NativeAOT. This cannot happen in a Roslyn source generator (as is usual), since query processing requires the EF model, which cannot be built/accessed in the Roslyn context.

As a result, we are planning to perform this process via msbuild integration, most likely as part of publishing (this is already where the very lengthy NativeAOT compilation takes place, etc.).
@roji roji added this to the 9.0.0 milestone Feb 15, 2024
@roji roji mentioned this issue Feb 15, 2024
Closed
38 tasks
AndriySvyryd added a commit that referenced this issue May 17, 2024
@AndriySvyryd
Add precompiled query generation to the dbcontext optimize command
edf121b 
Part of #33103
@AndriySvyryd AndriySvyryd mentioned this issue May 17, 2024
Merged
AndriySvyryd added a commit that referenced this issue May 18, 2024
@AndriySvyryd
Add precompiled query generation to the dbcontext optimize command
881f8e9 
Part of #33103
AndriySvyryd added a commit that referenced this issue May 21, 2024
@AndriySvyryd
Add precompiled query generation to the dbcontext optimize command
b840cc6 
Part of #33103
AndriySvyryd added a commit that referenced this issue May 21, 2024
@AndriySvyryd
Add precompiled query generation to the dbcontext optimize command
9227ea5 
Part of #33103
AndriySvyryd added a commit that referenced this issue May 22, 2024
@AndriySvyryd
Add precompiled query generation to the dbcontext optimize command
7c52f9f 
Part of #33103
AndriySvyryd added a commit that referenced this issue May 23, 2024
@AndriySvyryd
Add precompiled query generation to the dbcontext optimize command
07ea081 
Part of #33103
@AndriySvyryd AndriySvyryd added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label May 24, 2024
@AndriySvyryd AndriySvyryd removed their assignment May 24, 2024
AndriySvyryd added a commit that referenced this issue May 24, 2024
@AndriySvyryd
Add precompiled query generation to the dbcontext optimize command
f557e65 
Part of #33103
AndriySvyryd added a commit that referenced this issue May 31, 2024
@AndriySvyryd
Add precompiled query generation to the dbcontext optimize command
e370bfc 
Part of #33103
AndriySvyryd added a commit that referenced this issue Jun 5, 2024
@AndriySvyryd
Add precompiled query generation to the dbcontext optimize command
6fb60a1 
Part of #33103
AndriySvyryd added a commit that referenced this issue Jun 6, 2024
@AndriySvyryd
Add precompiled query generation to the dbcontext optimize command
7d016cd 
Part of #33103
AndriySvyryd added a commit that referenced this issue Jun 7, 2024
@AndriySvyryd
Add precompiled query generation to the dbcontext optimize command (#…
4b80cb9 
…33747)

Auto-generate compiled models for all contexts in the given assembly unless a single one is specified

Part of #33103
Fixes #33558
@ajcvickers ajcvickers modified the milestones: 9.0.0, 9.0.0-preview6 Jun 7, 2024
@AndriySvyryd AndriySvyryd mentioned this issue Sep 26, 2024
Closed
@roji roji modified the milestones: 9.0.0-preview6, 9.0.0 Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-aot area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
9.0.0
Development

Successfully merging a pull request may close this issue.

Add precompiled query generation to the dbcontext optimize command dotnet/efcore
3 participants
@ajcvickers @roji @AndriySvyryd