Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Design tests to Microsoft.EntityFrameworkCore.Specification.Tests #32315

Open
AndriySvyryd opened this issue Nov 16, 2023 · 2 comments
Open

Move Design tests to Microsoft.EntityFrameworkCore.Specification.Tests #32315

AndriySvyryd opened this issue Nov 16, 2023 · 2 comments
Assignees
@AndriySvyryd
Labels
area-test type-enhancement
Milestone
MQ

Comments

@AndriySvyryd
Copy link
Member

Microsoft.EntityFrameworkCore.Design.Tests should only contain tests that don't connect to the database.
@roji
Copy link
Member

roji commented Nov 16, 2023

Should this just go into Microsoft.EntityFrameworkCore.Specification.Tests (or its relational counterpart), i.e. do we need a separate new package for design tests?

@ajcvickers
Copy link
Member

ajcvickers commented Nov 17, 2023 •
edited
Loading

Notes from triage:

  • Design tests will go in the functional tests for the given provider
    • This will mean Cosmos tests have reference to Relational package, which isn't ideal, but is probably not too bad.
  • Other "black box" tests that can/should be overridden by providers will also move so that they are shipped on NuGet.

@ajcvickers ajcvickers added this to the MQ milestone Nov 17, 2023
AndriySvyryd added a commit that referenced this issue Nov 18, 2023
@AndriySvyryd
Move compiled model tests to EFCore.Specification.Tests
ba7b8a7 
Part of #32315
AndriySvyryd added a commit that referenced this issue Nov 18, 2023
@AndriySvyryd
Move compiled model tests to EFCore.Specification.Tests
abf4c18 
Part of #32315
@AndriySvyryd AndriySvyryd mentioned this issue Nov 18, 2023
Merged
AndriySvyryd added a commit that referenced this issue Nov 18, 2023
@AndriySvyryd
Move compiled model tests to EFCore.Specification.Tests
1e5f145 
Part of #32315
AndriySvyryd added a commit that referenced this issue Nov 18, 2023
@AndriySvyryd
Move compiled model tests to EFCore.Specification.Tests
f44192f 
Part of #32315
AndriySvyryd added a commit that referenced this issue Nov 21, 2023
@AndriySvyryd
Move compiled model tests to EFCore.Specification.Tests (#32341)
b385818 
Part of #32315
@AndriySvyryd AndriySvyryd changed the title Create and publish Microsoft.EntityFrameworkCore.Design.Specification.Tests Move Design tests to Microsoft.EntityFrameworkCore.Specification.Tests Dec 6, 2023
AndriySvyryd added a commit that referenced this issue Dec 6, 2023
@AndriySvyryd
Move ModelBuilding tests to EFCore.Specification.Tests
cdc5d1c 
Fix found issues

Part of #32315
@AndriySvyryd AndriySvyryd mentioned this issue Dec 6, 2023
Merged
AndriySvyryd added a commit that referenced this issue Dec 6, 2023
@AndriySvyryd
Move ModelBuilding tests to EFCore.Specification.Tests
5547a04 
Fix found issues

Part of #32315
AndriySvyryd added a commit that referenced this issue Dec 6, 2023
@AndriySvyryd
Move ModelBuilding tests to EFCore.Specification.Tests
d65c26b 
Fix found issues

Part of #32315
AndriySvyryd added a commit that referenced this issue Dec 7, 2023
@AndriySvyryd
Move ModelBuilding tests to EFCore.Specification.Tests (#32530)
9d68988 
Fix found issues

Part of #32315
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndriySvyryd AndriySvyryd

Labels
area-test type-enhancement
Projects
None yet
Milestone
MQ
Development

No branches or pull requests
3 participants
@ajcvickers @roji @AndriySvyryd