Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Json: add support for Sqlite provider #28816

Closed
maumar opened this issue Aug 21, 2022 · 2 comments · Fixed by #30302
Closed

Json: add support for Sqlite provider #28816

maumar opened this issue Aug 21, 2022 · 2 comments · Fixed by #30302
Assignees
@maumar
Labels
area-json area-sqlite closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
8.0.0

Comments

@maumar
Copy link
Contributor

maumar commented Aug 21, 2022

Currently Json support is only for SqlServer, we should light it up for sqlite also. Infrastructure is in relational so this shouldn't be too much work
@ajcvickers ajcvickers added this to the Backlog milestone Aug 22, 2022
@ajcvickers
Copy link
Contributor

Consider a better exception if we don't get to this in 8: #29632

@ajcvickers ajcvickers mentioned this issue Nov 24, 2022
Closed
@roji roji mentioned this issue Nov 25, 2022
Closed
maumar added a commit that referenced this issue Feb 15, 2023
@maumar
Fix to #28816 - Json: add support for Sqlite provider
aff265e 
Adding support for Sqlite.

Limitation:
When accessing element of a JSON array we can only use constant values. Unlike Sql Server which supports parameters, columns or even arbitrary expressions.

Fixes #28816
maumar added a commit that referenced this issue Feb 17, 2023
@maumar
Fix to #28816 - Json: add support for Sqlite provider
2bf4e3d 
Adding support for Sqlite.

Limitation:
When accessing element of a JSON array we can only use constant values. Unlike Sql Server which supports parameters, columns or even arbitrary expressions.

Fixes #28816
@maumar maumar mentioned this issue Feb 17, 2023
Merged
maumar added a commit that referenced this issue Feb 17, 2023
@maumar
Fix to #28816 - Json: add support for Sqlite provider
7dd826e 
Adding support for Sqlite.

Limitation:
When accessing element of a JSON array we can only use constant values. Unlike Sql Server which supports parameters, columns or even arbitrary expressions.

Fixes #28816
maumar added a commit that referenced this issue Feb 17, 2023
@maumar
Fix to #28816 - Json: add support for Sqlite provider
2c6e447 
Adding support for Sqlite.

Limitation:
When accessing element of a JSON array we can only use constant values. Unlike Sql Server which supports parameters, columns or even arbitrary expressions.

Fixes #28816
@maumar maumar added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Feb 17, 2023
@maumar maumar modified the milestones: Backlog, 8.0.0 Feb 17, 2023
maumar added a commit that referenced this issue Feb 23, 2023
@maumar
Fix to #28816 - Json: add support for Sqlite provider
e5adba7 
Adding support for Sqlite.
Also adding some more query and update tests for properties with value converters.

Limitation:
When accessing element of a JSON array we can only use constant values. Unlike Sql Server which supports parameters, columns or even arbitrary expressions.

Fixes #28816
maumar added a commit that referenced this issue Feb 23, 2023
@maumar
Fix to #28816 - Json: add support for Sqlite provider
4e32563 
Adding support for Sqlite.
Also adding some more query and update tests for properties with value converters.

Limitation:
When accessing element of a JSON array we can only use constant values. Unlike Sql Server which supports parameters, columns or even arbitrary expressions.

Fixes #28816
maumar added a commit that referenced this issue Feb 24, 2023
@maumar
Fix to #28816 - Json: add support for Sqlite provider
0db38cf 
Adding support for Sqlite.
Also adding some more query and update tests for properties with value converters.

Fixes #28816
maumar added a commit that referenced this issue Feb 24, 2023
@maumar
Fix to #28816 - Json: add support for Sqlite provider
201fe76 
Adding support for Sqlite.
Also adding some more query and update tests for properties with value converters.

Fixes #28816
maumar added a commit that referenced this issue Feb 24, 2023
@maumar
Fix to #28816 - Json: add support for Sqlite provider (#30302)
358b9ca 
Adding support for Sqlite.
Also adding some more query and update tests for properties with value converters.

Fixes #28816
@ajcvickers ajcvickers modified the milestones: 8.0.0, 8.0.0-preview2 Feb 25, 2023
@mattiasw2 mattiasw2 mentioned this issue Mar 2, 2023
Closed
@maumar maumar mentioned this issue Mar 2, 2023
Closed
@ajcvickers ajcvickers mentioned this issue Mar 3, 2023
Closed
@maumar maumar mentioned this issue Jun 17, 2023
Closed
@Jogai
Copy link

Jogai commented Sep 15, 2023 •
edited
Loading

Consider a better exception if we don't get to this in 8: #29632

A better exception in 7 would've been nice too. This is what npgsql does: https://github.com/npgsql/efcore.pg/blob/03f9eb362cdd116b66af0c2c08983368b080d569/src/EFCore.PG/Infrastructure/Internal/NpgsqlModelValidator.cs#L197

I was really pulling my hair out over this one.

@ajcvickers ajcvickers modified the milestones: 8.0.0-preview2, 8.0.0 Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maumar maumar

Labels
area-json area-sqlite closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

Fix to #28816 - Json: add support for Sqlite provider dotnet/efcore
4 participants
@bricelam @Jogai @ajcvickers @maumar