Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tools: Add dotnet-ef shims arm64 #27827

Closed
bricelam opened this issue Apr 15, 2022 · 1 comment
Closed

Tools: Add dotnet-ef shims arm64 #27827

bricelam opened this issue Apr 15, 2022 · 1 comment
Assignees
@bricelam
Labels
area-tools closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. Servicing-approved type-cleanup
Milestone
6.0.6

Comments

@bricelam
Copy link
Contributor

IIRC, this was just here to work around an SDK bug. Or maybe it was for signing. I don't remember.

If it's still needed, should it include win-arm and win-arm64?
@bricelam bricelam self-assigned this Apr 15, 2022
@bricelam bricelam mentioned this issue Apr 15, 2022
Merged
@ajcvickers ajcvickers added this to the MQ milestone Apr 22, 2022
@bricelam bricelam removed this from the MQ milestone Apr 27, 2022
@bricelam
Copy link
Contributor Author

See #27787 (comment)

@bricelam bricelam changed the title Does dotnet-ef still need PackAsToolShimRuntimeIdentifiers? Tools: Add dotnet-ef shims arm64 (and arm) Apr 27, 2022
bricelam added a commit to bricelam/efcore that referenced this issue May 5, 2022
@bricelam
Tools: Target .NET 6 to improve compatibility with osx-arm64
24a74ed 
Also adds a shim we can sign for win-arm64 and rolls ef.dll forward across major runtime versions.

Fixes dotnet#27787, fixes dotnet#27827
@bricelam bricelam added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label May 5, 2022
@bricelam bricelam changed the title Tools: Add dotnet-ef shims arm64 (and arm) Tools: Add dotnet-ef shims arm64 May 13, 2022
@bricelam bricelam added this to the 6.0.6 milestone May 13, 2022
@ajcvickers ajcvickers mentioned this issue Jun 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bricelam bricelam

Labels
area-tools closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. Servicing-approved type-cleanup
Projects
None yet
Milestone
6.0.6
Development

No branches or pull requests
2 participants
@bricelam @ajcvickers