Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate slow text templating tests on Linux #27598

Open
bricelam opened this issue Mar 9, 2022 · 1 comment
Open

Investigate slow text templating tests on Linux #27598

bricelam opened this issue Mar 9, 2022 · 1 comment
Labels
area-perf area-scaffolding area-test type-cleanup
Milestone
MQ

Comments

@bricelam
Copy link
Contributor

bricelam commented Mar 9, 2022

For some reason, adding the following tests to EFCore.Design.Tests caused the Linux CI build to go from 16 minutes to timing out at 2 hours.

  • TextTemplatingModelGeneratorTest
  • TextTemplatingServiceTest

I've skipped running them on Linux for now, but we should follow up and investigate why they're taking so long there.
@bricelam bricelam self-assigned this Mar 9, 2022
@bricelam bricelam mentioned this issue Mar 9, 2022
Merged
3 tasks
@ajcvickers ajcvickers added this to the 7.0.0 milestone Mar 9, 2022
bricelam added a commit to bricelam/efcore that referenced this issue Jul 1, 2022
@bricelam
Scaffolding: Refactor some code
8895fe1 
Part of dotnet#4038, part of dotnet#27588, fixes dotnet#27598, resolves dotnet#8434, resolves dotnet#21882, fixes dotnet#26349
@bricelam bricelam mentioned this issue Jul 1, 2022
Merged
@bricelam bricelam added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jul 1, 2022
@bricelam bricelam modified the milestones: 7.0.0, 7.0.0-preview6 Jul 1, 2022
@bricelam bricelam removed the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jul 7, 2022
@bricelam
Copy link
Contributor Author

bricelam commented Aug 9, 2022

Hmm, more T4-related tests also seem to be causing timeouts on macOS.

  • CSharpDbContextGeneratorTest
  • CSharpEntityTypeGeneratorTest

bricelam added a commit to bricelam/efcore that referenced this issue Aug 24, 2022
@bricelam
Scaffolding: Avoid recompiling T4 templates
d11c2ee 
This dramatically improves the performance of the commands.

Part of dotnet#27598
@bricelam bricelam mentioned this issue Aug 24, 2022
Merged
bricelam added a commit to bricelam/efcore that referenced this issue Aug 25, 2022
@bricelam
Scaffolding: Avoid recompiling T4 templates
a2f6746 
This dramatically improves the performance of the commands.

Part of dotnet#27598
@bricelam bricelam removed this from the 7.0.0 milestone Aug 29, 2022
@ajcvickers ajcvickers added this to the MQ milestone Aug 31, 2022
@bricelam bricelam removed their assignment Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-perf area-scaffolding area-test type-cleanup
Projects
None yet
Milestone
MQ
Development

No branches or pull requests
3 participants
@bricelam @ajcvickers @roji