Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop throwing for optional FKs if delete orphans timing is set to Never. #27218

Closed
ajcvickers opened this issue Jan 19, 2022 · 0 comments · Fixed by #27557
Closed

Stop throwing for optional FKs if delete orphans timing is set to Never. #27218

ajcvickers opened this issue Jan 19, 2022 · 0 comments · Fixed by #27557
Labels
area-change-tracking closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone
7.0.0

Comments

@ajcvickers
Copy link
Contributor

See #27174.
@ajcvickers ajcvickers self-assigned this Jan 19, 2022
This was referenced Jan 19, 2022
Merged
Closed
@ajcvickers ajcvickers added this to the 7.0.0 milestone Jan 22, 2022
ajcvickers added a commit that referenced this issue Mar 2, 2022
@ajcvickers
Stop deleting orphans for optional relationships configured for casca…
2e64a62 
…de deletes

Fixes #27217
Fixes #27218

The 5.0/6.0 behavior here is:
- Orphans are deleted if the relationship is severed by navigation property
- Orphans are not deleted if the relationship is severed by setting the FK to null

This change means orphans are not deleted in either case. The change that causes this to happen is to not set a conceptual null for a nullable FK property. Deletion can still be forced by explicitly forcing a conceptual null or just by setting the dependent state explicitly to Deleted.
@ajcvickers ajcvickers mentioned this issue Mar 2, 2022
Merged
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Mar 2, 2022
@ajcvickers ajcvickers modified the milestones: 7.0.0, 7.0.0-preview3 Mar 15, 2022
@ajcvickers ajcvickers modified the milestones: 7.0.0-preview3, 7.0.0 Nov 5, 2022
@ajcvickers ajcvickers removed their assignment Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-change-tracking closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

Stop deleting orphans for optional relationships configured for cascade deletes dotnet/efcore
1 participant
@ajcvickers