Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't create proxy types is there is nothing to proxy #22336

Open
Tracked by #22954
ajcvickers opened this issue Aug 31, 2020 · 0 comments
Open
Tracked by #22954

Don't create proxy types is there is nothing to proxy #22336

ajcvickers opened this issue Aug 31, 2020 · 0 comments
Labels
area-change-tracking area-perf type-enhancement
Milestone
Backlog

Comments

@ajcvickers
Copy link
Contributor

For example, if there are no interfaces to add and no methods to override.
ajcvickers added a commit that referenced this issue Aug 31, 2020
@ajcvickers
Updates to shared-type entity type handling in proxies
29785fc 
Fixes #22337

* Check for virtual indexer properties and throw unless type is Dictionary<string, _> and has only primary keys
* Specific exception for the Dictionary case
* Verified many-to-many with payload requires this pattern and works

See also #22336
@ajcvickers ajcvickers mentioned this issue Aug 31, 2020
Closed
ajcvickers added a commit that referenced this issue Sep 1, 2020
@ajcvickers
Updates to shared-type entity type handling in proxies
bef7f3e 
Fixes #22337

* Check for virtual indexer properties and throw unless type is Dictionary<string, _> and has only primary keys
* Specific exception for the Dictionary case
* Verified many-to-many with payload requires this pattern and works

See also #22336
@JeremyLikness JeremyLikness added this to the Backlog milestone Sep 4, 2020
@AndriySvyryd AndriySvyryd mentioned this issue Jan 14, 2022
Open
46 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-change-tracking area-perf type-enhancement
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@ajcvickers @JeremyLikness