Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query: incorrect order for query with ordered filtered include using ROW_NUMBER #21338

Closed
maumar opened this issue Jun 19, 2020 · 0 comments · Fixed by #21337
Closed

Query: incorrect order for query with ordered filtered include using ROW_NUMBER #21338

maumar opened this issue Jun 19, 2020 · 0 comments · Fixed by #21337
Assignees
@smitpatel
Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone
5.0.0

Comments

@maumar
Copy link
Contributor

maumar commented Jun 19, 2020

failing queries:
Filtered_include_same_filter_set_on_same_navigation_twice
Filtered_include_after_different_filtered_include_same_level

looking at the sql problem also happens in other filtered include queries, but they pass serendipitously

problem introduced in 0fa2d3c
We don't propagate orderings used inside ROW_NUMBER function to the top level order by
@maumar maumar changed the title Query: incorrect data for query with ordered filtered include Query: incorrect data for query with ordered filtered include using ROW_NUMBER Jun 19, 2020
@maumar maumar changed the title Query: incorrect data for query with ordered filtered include using ROW_NUMBER Query: incorrect order for query with ordered filtered include using ROW_NUMBER Jun 19, 2020
@smitpatel smitpatel self-assigned this Jun 19, 2020
@smitpatel smitpatel added this to the 5.0.0 milestone Jun 19, 2020
smitpatel added a commit that referenced this issue Jun 19, 2020
@smitpatel
Query: Fix ordering for filtered include in single query scenario
ec8f5b7 
Resolves #21338

Also Clean up execution strategy in QueryingEnumerables
Resolves #21211
@smitpatel smitpatel added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jun 19, 2020
@smitpatel smitpatel mentioned this issue Jun 19, 2020
Merged
smitpatel added a commit that referenced this issue Jun 19, 2020
@smitpatel
Query: Fix ordering for filtered include in single query scenario
3db21e1 
Resolves #21338

Also Clean up execution strategy in QueryingEnumerables
Resolves #21211
smitpatel added a commit that referenced this issue Jun 19, 2020
@smitpatel
Query: Fix ordering for filtered include in single query scenario
2fe140f 
Resolves #21338

Also Clean up execution strategy in QueryingEnumerables
Resolves #21211
smitpatel added a commit that referenced this issue Jun 23, 2020
@smitpatel
Query: Fix ordering for filtered include in single query scenario (#2…
c12fd02 
…1337)

Resolves #21338

Also Clean up execution strategy in QueryingEnumerables
Resolves #21211
@ajcvickers ajcvickers modified the milestones: 5.0.0, 5.0.0-preview8 Jul 14, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0-preview8, 5.0.0 Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smitpatel smitpatel

Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Query: Fix ordering for filtered include in single query scenario dotnet/efcore
3 participants
@ajcvickers @smitpatel @maumar