Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query: Key comparison for collection nav throws when PK is struct #19407

Closed
smitpatel opened this issue Dec 26, 2019 · 3 comments · Fixed by #21742
Closed

Query: Key comparison for collection nav throws when PK is struct #19407

smitpatel opened this issue Dec 26, 2019 · 3 comments · Fixed by #21742
Assignees
@smitpatel
Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. poachable type-bug
Milestone
5.0.0

Comments

@smitpatel
Copy link
Member

See #13507 (comment)

We use Expression.Equal always, which does not work for value type which does not define Equal operator.

Few options

  • We can always use Equals operator which translate to the same thing. (need to verify this)
  • We can make it conditional that use Expression.Equal only when possible.
@smitpatel smitpatel mentioned this issue Dec 26, 2019
Closed
@ajcvickers ajcvickers added this to the 5.0.0 milestone Jan 3, 2020
@smitpatel
Copy link
Member Author

Wait for #13507 to add test classes.

@smitpatel smitpatel removed the blocked label Feb 14, 2020
@smitpatel
Copy link
Member Author

@ajcvickers - Were there tests added for this in source?

@ajcvickers
Copy link
Member

Change the structs in this file:

efcore/test/EFCore.Specification.Tests/KeysWithConvertersTestBase.cs

Line 1807 in c2c469d

#pragma warning disable 660,661 // Issue #19407

smitpatel added a commit that referenced this issue Jul 22, 2020
@smitpatel
Query: Key comparison should use object.Equals internally in query
fc13f49 
And associated changes to support translation.

Resolves #19407
smitpatel added a commit that referenced this issue Jul 22, 2020
@smitpatel
Query: Key comparison should use object.Equals internally in query
828a86c 
And associated changes to support translation.

Resolves #19407
@smitpatel smitpatel mentioned this issue Jul 22, 2020
Merged
@ghost ghost closed this as completed in #21742 Jul 22, 2020
ghost pushed a commit that referenced this issue Jul 22, 2020
@smitpatel
Query: Key comparison should use object.Equals internally in query (#…
b083ed3 
…21742)

And associated changes to support translation.

Resolves #19407
@smitpatel smitpatel added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jul 23, 2020
@smitpatel smitpatel mentioned this issue Jul 23, 2020
Merged
@ajcvickers ajcvickers modified the milestones: 5.0.0, 5.0.0-rc1 Aug 14, 2020
@smitpatel smitpatel mentioned this issue Oct 28, 2020
Closed
@ajcvickers ajcvickers modified the milestones: 5.0.0-rc1, 5.0.0 Nov 7, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smitpatel smitpatel

Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. poachable type-bug
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Query: Key comparison should use object.Equals internally in query dotnet/efcore
2 participants
@ajcvickers @smitpatel