Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove RemoveConvert API #17529

Closed
smitpatel opened this issue Aug 30, 2019 · 1 comment
Closed

Remove RemoveConvert API #17529

smitpatel opened this issue Aug 30, 2019 · 1 comment
Labels
breaking-change closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-cleanup
Milestone
5.0.0

Comments

@smitpatel
Copy link
Contributor

We stopped using it in our stack due to new design & #13908

We still haven't removed the public API. We should remove it in next breaking change.
@ajcvickers ajcvickers added this to the 3.1.0 milestone Sep 6, 2019
@ajcvickers
Copy link
Contributor

Obsolete in 3.1.

smitpatel added a commit that referenced this issue Sep 8, 2019
@smitpatel
Obsolete RemoveConvert API as it should not be used
2be14ca 
Part of #17529
@smitpatel smitpatel mentioned this issue Sep 8, 2019
Merged
@smitpatel smitpatel modified the milestones: 3.1.0, 5.0 Sep 8, 2019
smitpatel added a commit that referenced this issue Sep 8, 2019
@smitpatel
Obsolete RemoveConvert API as it should not be used
5534002 
Part of #17529
smitpatel added a commit that referenced this issue Sep 8, 2019
@smitpatel
Obsolete RemoveConvert API as it should not be used
ce2fe0c 
Part of #17529
@smitpatel smitpatel modified the milestones: 5.0, Backlog Sep 9, 2019
@smitpatel smitpatel removed their assignment Sep 14, 2019
@ajcvickers ajcvickers modified the milestones: Backlog, 5.0.0 Nov 6, 2019
@ajcvickers ajcvickers self-assigned this Nov 6, 2019
@ajcvickers ajcvickers added closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. and removed consider-for-current-release labels Nov 6, 2019
ajcvickers added a commit that referenced this issue Nov 6, 2019
@ajcvickers
Remove obsolete code from master ready for 5.0
523dc18 
Fixes #18784 #17529 #18700 #18539
@ajcvickers ajcvickers mentioned this issue Nov 6, 2019
Merged
ajcvickers added a commit that referenced this issue Nov 8, 2019
@ajcvickers
Remove obsolete code from master ready for 5.0
cf43c92 
Fixes #18784 #17529 #18700 #18539
ajcvickers added a commit that referenced this issue Nov 8, 2019
@ajcvickers
Remove obsolete code from master ready for 5.0
7aa0e2c 
Fixes #18784 #17529 #18700 #18539
@ajcvickers ajcvickers modified the milestones: 5.0.0, 5.0.0-preview1 Mar 13, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0-preview1, 5.0.0 Nov 7, 2020
@ajcvickers ajcvickers removed their assignment Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-cleanup
Projects
None yet
Milestone
5.0.0
Development

No branches or pull requests
2 participants
@ajcvickers @smitpatel