Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sqlite: Throw on blocked translation of aggregate #17449

Closed
smitpatel opened this issue Aug 27, 2019 · 2 comments · Fixed by #21392
Closed

Sqlite: Throw on blocked translation of aggregate #17449

smitpatel opened this issue Aug 27, 2019 · 2 comments · Fixed by #21392
Assignees
@smitpatel
Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. punted-for-3.1 type-bug
Milestone
5.0.0

Comments

@smitpatel
Copy link
Member

Currently it returns null.
It should rather throw exception with why aggregate was blocked. Aggregate operations are never going to be evaluated on client even if in projection.
@ajcvickers ajcvickers added this to the 3.1.0 milestone Aug 30, 2019
@ajcvickers ajcvickers assigned ajcvickers and bricelam and unassigned ajcvickers Aug 30, 2019
@ajcvickers
Copy link
Member

From triage: also, we should change the exception message for the cases specific to SQLite to be more specific to the SQLite problem. Also check the OrderBy case.

@ajcvickers ajcvickers modified the milestones: 3.1.0, Backlog Oct 11, 2019
@bricelam bricelam modified the milestones: Backlog, 5.0.0 Nov 5, 2019
@smitpatel smitpatel self-assigned this Mar 12, 2020
@ajcvickers ajcvickers assigned maumar and smitpatel and unassigned bricelam, smitpatel and maumar Jun 8, 2020
@smitpatel
Copy link
Member Author

OrderBy case already shows message

SQLite cannot order by expressions of type '{type}'. Convert the values to a supported type or use LINQ to Objects to order the results.

@smitpatel smitpatel added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jun 23, 2020
smitpatel added a commit that referenced this issue Jun 23, 2020
@smitpatel
Sqlite: Throw on blocked translation of aggregate
845fa06 
Resolves #17449
@smitpatel smitpatel mentioned this issue Jun 23, 2020
Merged
smitpatel added a commit that referenced this issue Jun 24, 2020
@smitpatel
Sqlite: Throw on blocked translation of aggregate (#21392)
b7d276a 
Resolves #17449
@ajcvickers ajcvickers modified the milestones: 5.0.0, 5.0.0-preview8 Jul 14, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0-preview8, 5.0.0 Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smitpatel smitpatel

Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. punted-for-3.1 type-bug
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Sqlite: Throw on blocked translation of aggregate dotnet/efcore
4 participants
@bricelam @ajcvickers @smitpatel @maumar