Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SqlExpressionVisitorDependency object #16846

Closed
smitpatel opened this issue Jul 30, 2019 · 0 comments
Closed

Remove SqlExpressionVisitorDependency object #16846

smitpatel opened this issue Jul 30, 2019 · 0 comments
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone
3.0.0

Comments

@smitpatel
Copy link
Contributor

It's not service. There is no factory to create it. It is a base class like ExpressionVisitor to allow double dispatch. Dependency object for it should be removed and be added for classes which implements it.
ajcvickers added a commit that referenced this issue Jul 30, 2019
@ajcvickers
SqlExpressionVisitorDependency -> QuerySqlGeneratorDependencies
4425ab8 
Fixes #16846
@ajcvickers ajcvickers mentioned this issue Jul 30, 2019
Merged
@ajcvickers ajcvickers added this to the 3.0.0-preview8 milestone Jul 30, 2019
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jul 30, 2019
@ajcvickers ajcvickers self-assigned this Jul 30, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0-preview8, 3.0.0 Nov 11, 2019
@ajcvickers ajcvickers removed their assignment Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
2 participants
@ajcvickers @smitpatel