Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate overloads in MigrationsSqlGenerator #16654

Closed
roji opened this issue Jul 18, 2019 · 2 comments · Fixed by #16673
Closed

Consolidate overloads in MigrationsSqlGenerator #16654

roji opened this issue Jul 18, 2019 · 2 comments · Fixed by #16673
Assignees
@roji
Labels
breaking-change closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-cleanup
Milestone
3.0.0

Comments

@roji
Copy link
Member

roji commented Jul 18, 2019

I noticed that in MigrationsSqlGenerator we still have two overloads per operation, one receiving a terminate flag, and another which doesn't (and delegates to the first). Should we take this opportunity to clean this up, or is there some reason for this?

/cc @bricelam
@bricelam
Copy link
Contributor

Hmm, in my head there are reasons, but they may be artificial. lol, we should investigate.

@roji roji self-assigned this Jul 19, 2019
@roji roji changed the title Consolidate overloads in MigrationsSqlGenerator? Consolidate overloads in MigrationsSqlGenerator Jul 19, 2019
@roji roji added this to the 3.0.0 milestone Jul 19, 2019
roji added a commit that referenced this issue Jul 19, 2019
@roji
Consolidate terminate overloads in MigrationsSqlGenerator
9c78072 
Closes #16654
@roji roji mentioned this issue Jul 19, 2019
Merged
roji added a commit that referenced this issue Jul 20, 2019
@roji
Consolidate terminate overloads in MigrationsSqlGenerator
28fe450 
Closes #16654
@roji
Copy link
Member Author

roji commented Jul 20, 2019

@ajcvickers note that I added this to the 3.0 milestone and added labels. PR has already been merged.

@bricelam bricelam added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jul 21, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0, 3.0.0-preview8 Jul 29, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0-preview8, 3.0.0 Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roji roji

Labels
breaking-change closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-cleanup
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Consolidate terminate overloads in MigrationsSqlGenerator dotnet/efcore
3 participants
@bricelam @ajcvickers @roji