-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eliminate nullability-only Convert nodes #16653
Labels
closed-fixed
The issue has been fixed and is/will be included in the release indicated by the issue milestone.
type-enhancement
Milestone
Comments
There is already check in place to make sure if the convert node is converting from T to T? we remove it. |
roji
added a commit
that referenced
this issue
Jul 18, 2019
roji
added a commit
that referenced
this issue
Jul 18, 2019
roji
added a commit
that referenced
this issue
Jul 18, 2019
Fix reverted due to un-updated SQL baselines. |
roji
added
the
closed-fixed
The issue has been fixed and is/will be included in the release indicated by the issue milestone.
label
Jul 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
closed-fixed
The issue has been fixed and is/will be included in the release indicated by the issue milestone.
type-enhancement
Given the following query:
we get the following tree (since OrderDate is nullable):
which makes us generate the following over-complicated SQL:
FWIW I think the old pipeline didn't have this useless cast.
The text was updated successfully, but these errors were encountered: