EntityEquality generates type mismatch

[smitpatel]

Test: Contains_over_entityType_with_null_should_rewrite_to_identity_equality

                var query
                    = context.Orders.Where(o => o.CustomerID == "VINET")
                        .Contains(null);

bool Contains(
|__ source: IQueryable<Order> Where(
|   |__ source: DbSet<Order>, 
|   |__ predicate: (Order o) => o.CustomerID == "VINET"), 
|__ item: (Unhandled parameter: __p_0))

// Gets rewritten into

bool Contains(
|__ source: IQueryable<int> Select(
|   |__ source: IQueryable<Order> Where(
|   |   |__ source: DbSet<Order>, 
|   |   |__ predicate: (Order Param_0) => Param_0.CustomerID == "VINET"), 
|   |__ selector: (Order Param_0) => Property(Param_0, "OrderID")), 
|__ item: (Unhandled parameter: __entity_equality_p_0_OrderID))

here p0 is null so runtime generated parameter is also null. But value is being cast to int which is NRE. When rewriting key access on potentially null expression, it should convert the types to nullable.

[smitpatel]

Another case

IQueryable<Customer> Where(
|__ source: DbSet<Customer>, 
|__ predicate: (Customer c) => Order FirstOrDefault(IOrderedEnumerable<Order> OrderBy(
    |__ source: c.Orders, 
    |__ keySelector: (Order o) => o.OrderID)) == Order 10243)

It generates property access of type int on FOD.
Which nav expansion after member pushdown generates this

IQueryable<Customer> Where(
|__ source: DbSet<Customer>, 
|__ predicate: (Customer Param_0) => (int)Nullable<int> FirstOrDefault(IQueryable<Nullable<int>> Select(
    |__ source: IOrderedQueryable<Order> OrderBy(
    |   |__ source: IQueryable<Order> Where(
    |   |   |__ source: DbSet<Order>, 
    |   |   |__ predicate: (Order o) =>  ?= Property(Param_0, "CustomerID") == Property(o, "CustomerID") =? ), 
    |   |__ keySelector: (Order Param_0) => Param_0.OrderID), 
    |__ selector: (Order Param_0) => (Nullable<int>)Property(Param_0, "OrderID"))) == 10243)

This throw NRE in InMemory.

[roji]

Sorry, my github email notifications are clearly not working well - missed this. Will check it out as soon as the preview7 port is done.

[roji]

@smitpatel I see the issue you're describing. However, the first test (Contains_over_entityType_with_null_should_rewrite_to_identity_equality) passes correctly - do you have another repro in mind for relational?

Will investigate the second failure.

Regardless, will wait on #16791 to get merged to avoid conflicts.

[smitpatel]

InMemory failure. The test is disabled for InMemory provider with this bug number.