Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test: Verify code path when diagnostic source enabled but no interceptors registered #16352

Closed
smitpatel opened this issue Jun 28, 2019 · 1 comment · Fixed by #16290
Closed

Test: Verify code path when diagnostic source enabled but no interceptors registered #16352

smitpatel opened this issue Jun 28, 2019 · 1 comment · Fixed by #16290
Labels
area-test closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
3.0.0

Comments

@smitpatel
Copy link
Contributor

No description provided.

@smitpatel
Copy link
Contributor Author

Source code fix was added in #16348

@ajcvickers ajcvickers self-assigned this Jun 28, 2019
@ajcvickers ajcvickers added this to the 3.0.0 milestone Jun 28, 2019
ajcvickers added a commit that referenced this issue Jun 29, 2019
@ajcvickers
Better test coverage for interceptors and Diagnostics registered at t…
6d7e175 
…he same time

Fixes #16352
@ajcvickers ajcvickers mentioned this issue Jun 29, 2019
Merged
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jun 29, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0, 3.0.0-preview7 Jul 2, 2019
ajcvickers added a commit that referenced this issue Jul 2, 2019
@ajcvickers
Add Add correlation ID for DbContext like we have for DbCommand a…
fd698fa 
…nd `DbConnection`

Based on more feedback, now one ID and a lease number.

Fixes #16201

Better test coverage for interceptors and Diagnostics registered at the same time

Fixes #16352
ajcvickers added a commit that referenced this issue Jul 2, 2019
@ajcvickers
Add Add correlation ID for DbContext like we have for DbCommand a…
c55ee41 
…nd `DbConnection`

Based on more feedback, now one ID and a lease number.

Fixes #16201

Better test coverage for interceptors and Diagnostics registered at the same time

Fixes #16352
ajcvickers added a commit that referenced this issue Jul 2, 2019
@ajcvickers
Add Add correlation ID for DbContext like we have for DbCommand a…
d036eb8 
…nd `DbConnection`

Based on more feedback, now one ID and a lease number.

Fixes #16201

Better test coverage for interceptors and Diagnostics registered at the same time

Fixes #16352
ajcvickers added a commit that referenced this issue Jul 3, 2019
@ajcvickers
Add Add correlation ID for DbContext like we have for DbCommand a…
a5961cc 
…nd `DbConnection`

Based on more feedback, now one ID and a lease number.

Fixes #16201

Better test coverage for interceptors and Diagnostics registered at the same time

Fixes #16352
@ajcvickers ajcvickers modified the milestones: 3.0.0, 3.0.0-preview8 Jul 29, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0-preview8, 3.0.0 Nov 11, 2019
@ajcvickers ajcvickers removed their assignment Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-test closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Add Add correlation ID for DbContext… dotnet/efcore
2 participants
@ajcvickers @smitpatel