Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Entity Equality: support GroupBy #15938

Closed
roji opened this issue Jun 4, 2019 · 3 comments
Closed

Entity Equality: support GroupBy #15938

roji opened this issue Jun 4, 2019 · 3 comments
Labels
closed-duplicate punted-for-3.0

Comments

@roji
Copy link
Member

roji commented Jun 4, 2019

After GroupBy is reimplemented, entity equality should be able to traverse it and properly rewrite equality expressions.
@roji roji self-assigned this Jun 4, 2019
@roji
Copy link
Member Author

roji commented Jun 4, 2019

/cc @smitpatel

@roji roji mentioned this issue Jun 6, 2019
Merged
5 tasks
@ajcvickers ajcvickers added this to the 3.0.0 milestone Jun 6, 2019
@divega divega modified the milestones: 3.0.0, Backlog Jun 21, 2019
@maumar maumar mentioned this issue Aug 27, 2019
Closed
@maumar maumar mentioned this issue Oct 7, 2019
Closed
@maumar
Copy link
Contributor

maumar commented Oct 7, 2019

added (skipped) regression tests for this issue

@maumar maumar mentioned this issue Oct 7, 2019
Closed
maumar added a commit that referenced this issue Oct 8, 2019
@maumar
Adding tests for various group by scenarios
33bb759 
- added regression tests for #12289
- added regression tests for #15279
- added regression tests for #15938
- added regression tests for #18267

- resolves #12522
- resolves #12805
- resolves #13231
- resolves #13594
- resolves #13754
- resolves #14851
- resolves #15103
- resolves #15669
- resolves #15853
@maumar maumar mentioned this issue Oct 8, 2019
Merged
maumar added a commit that referenced this issue Oct 8, 2019
@maumar
Adding tests for various group by scenarios
3f68091 
- added regression tests for #12289
- added regression tests for #15279
- added regression tests for #15938
- added regression tests for #18267

- resolves #12522
- resolves #12805
- resolves #13231
- resolves #13594
- resolves #13754
- resolves #14851
- resolves #15103
- resolves #15669
- resolves #15853
maumar added a commit that referenced this issue Oct 8, 2019
@maumar
Adding tests for various group by scenarios
03ca42e 
- added regression tests for #12289
- added regression tests for #15279
- added regression tests for #15938
- added regression tests for #18267

- resolves #12522
- resolves #12805
- resolves #13231
- resolves #13594
- resolves #13754
- resolves #14851
- resolves #15103
- resolves #15669
- resolves #15853
maumar added a commit that referenced this issue Oct 8, 2019
@maumar
Adding tests for various group by scenarios (#18283)
5ced404 
- added regression tests for #12289
- added regression tests for #15279
- added regression tests for #15938
- added regression tests for #18267

- resolves #12522
- resolves #12805
- resolves #13231
- resolves #13594
- resolves #13754
- resolves #14851
- resolves #15103
- resolves #15669
- resolves #15853
@smitpatel
Copy link
Contributor

Related #20164

@smitpatel smitpatel assigned smitpatel and unassigned roji Mar 16, 2020
@smitpatel smitpatel removed their assignment Aug 27, 2020
@smitpatel smitpatel removed this from the Backlog milestone Sep 7, 2022
@smitpatel smitpatel closed this as not planned Won't fix, can't repro, duplicate, stale Sep 7, 2022
@ajcvickers ajcvickers reopened this Oct 16, 2022
@ajcvickers ajcvickers closed this as not planned Won't fix, can't repro, duplicate, stale Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-duplicate punted-for-3.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@divega @ajcvickers @smitpatel @maumar @roji