Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove DbFunction.DefaultSchema #15501

Closed
AndriySvyryd opened this issue Apr 26, 2019 · 4 comments · Fixed by #16166
Closed

Remove DbFunction.DefaultSchema #15501

AndriySvyryd opened this issue Apr 26, 2019 · 4 comments · Fixed by #16166
Assignees
@smitpatel
Labels
breaking-change closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-cleanup
Milestone
3.0.0

Comments

@AndriySvyryd
Copy link
Member

No description provided.

@AndriySvyryd AndriySvyryd self-assigned this Apr 26, 2019
@divega divega added this to the 3.0.0 milestone Apr 29, 2019
@divega
Copy link
Contributor

divega commented Apr 29, 2019

Note from triage: We may be able to get rid of this setting.

@smitpatel
Copy link
Member

related issue #12757

@ajcvickers ajcvickers changed the title Move DbFunction.DefaultSchema to Model.DbFunctionDefaultSchema Remove DbFunction.DefaultSchema May 10, 2019
@smitpatel smitpatel assigned smitpatel and unassigned AndriySvyryd Jun 19, 2019
@smitpatel
Copy link
Member

Poaching.

smitpatel added a commit that referenced this issue Jun 19, 2019
@smitpatel
Query: Add builtIn flag to SqlFunction and use it to quoting logic
1fc7152 
Fuctions without arguments passed considered niladic.
Non-niladic functions without arguments must pass empty array of args.
Functions with instance are considered built in.
Functions without schema are considered built in.
Functions with schema are non-built-in (Schema can be null)
To map a DbFunction to built-in function use HasTranslation API

Resolves #12757
Resolves #14882
Resolves #15501
@smitpatel smitpatel mentioned this issue Jun 19, 2019
Merged
@smitpatel smitpatel added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jun 19, 2019
@AndriySvyryd
Copy link
Member Author

@smitpatel I hoped you would 😉

smitpatel added a commit that referenced this issue Jun 21, 2019
@smitpatel
Query: Add builtIn flag to SqlFunction and use it to quoting logic
b775a93 
Fuctions without arguments passed considered niladic.
Non-niladic functions without arguments must pass empty array of args.
Functions with instance are considered built in.
Functions without schema are considered built in.
Functions with schema are non-built-in (Schema can be null)
To map a DbFunction to built-in function use HasTranslation API

Resolves #12757
Resolves #14882
Resolves #15501
@ajcvickers ajcvickers modified the milestones: 3.0.0, 3.0.0-preview7 Jul 2, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0-preview7, 3.0.0 Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smitpatel smitpatel

Labels
breaking-change closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-cleanup
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Query: Add builtIn flag to SqlFunction and use it to quoting logic dotnet/efcore
4 participants
@divega @ajcvickers @smitpatel @AndriySvyryd