Add TagWith overload that gets the filename and line number automatically

[ajcvickers]

As suggested/used by Nick Craver.

[jzabroski]

As suggested/used by Nick Craver

Are you referring to this tweet: https://twitter.com/Nick_Craver/status/1069999128082595847 ?

And this gist https://gist.github.com/NickCraver/c6f371bf8df37e05c4f09fd3c02ef6a2 ?

[ajcvickers]

@jzabroski Yes.

[michalczerwinski]

@ajcvickers: Is it something I can help with?

Please confirm the approach:

• adding custom extension method TagWith
• using [CallerFilePath]string fromFile = null, [CallerLineNumber]int onLine = 0 in the extension

What shall we call it? TagWithCallerInfo?

[ajcvickers]

@michalczerwinski Yes, that seems to be a reasonable approach. Naming is hard, but can this just be a new overload of TagWith rather getting a new name?

[michalczerwinski]

@ajcvickers: great! Will keep it as overload then.

[stevendarby]

Isn’t the usefulness of the caller attributes that they automatically set the optional parameters for you? As such, naming it TagWith() when passing no parameters reads slightly strangely to me.

[michalczerwinski]

@stevendarby: that's why I called it TagWithCallerInfo previously. But as @ajcvickers pointed out it's hard to call this method succinctly, so if you have better proposals?

[stevendarby]

@michalczerwinski I haven’t got a better suggestion than your previous one, which I thought was ok. Sorry to weigh in at this point, I just wondered if perhaps @ajcvickers’ suggestion was made without full realisation of how it reads when using the defaults (which is the main use case for this method). If that’s understood and TagWith is still preferred then so be it :)

[ajcvickers]

@michalczerwinski @stevendarby It doesn't really matter too much at this point since we have an API review process where we will look at all the names and possibly make changes then. Naming is hard; get the code changes done, and we can see what names works best later.